update permissions samples on testing.md - #1664
Merged
Merged
Conversation
kuboon
commented
Apr 25, 2025
| # Provide permission for deno to read from the filesystem, which is necessary | ||
| # for the final test above to pass | ||
| deno test --allow-read my_test.ts | ||
| deno test --allow-read=. my_test.ts |
Contributor
Author
There was a problem hiding this comment.
This is a bit of a personal preference, but I have a strong desire to promote the practice of not granting broad permissions too easily.
thisisjofrank
self-requested a review
May 1, 2025 10:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was confused by the permissions option in Deno.test, so I’d like to suggest a correction.
In the early example,
permissions: { read: true },is included, but the test actually passes even without it. I found this point unclear, so I think it should be removed.A more detailed explanation is provided in the
## Tests and Permissionssection, but including the unnecessarypermissions: { read: true },there as well makes the line "allows you to specifically deny permissions, but does not grant them." harder to understand.What do you think?